lkml.org 
[lkml]   [2010]   [Dec]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC v6 2/9] Documentation:DocBook:v4l: Update the controls.xml for TI FM driver
Em 03-12-2010 10:50, manjunatha_halli@ti.com escreveu:
> From: Manjunatha Halli <manjunatha_halli@ti.com>
>
> Added entries for following 2 new CID's which are added for TI FM
> driver:
> - V4L2_CID_RSSI_THRESHOLD
> - V4L2_CID_TUNE_AF
>
> Signed-off-by: Manjunatha Halli <manjunatha_halli@ti.com>
> ---
> Documentation/DocBook/v4l/controls.xml | 12 ++++++++++++
> 1 files changed, 12 insertions(+), 0 deletions(-)
>
> diff --git a/Documentation/DocBook/v4l/controls.xml b/Documentation/DocBook/v4l/controls.xml
> index 2fae3e8..b560953 100644
> --- a/Documentation/DocBook/v4l/controls.xml
> +++ b/Documentation/DocBook/v4l/controls.xml
> @@ -132,6 +132,18 @@ consumption state.</entry>
> <entry>Loudness mode (bass boost).</entry>
> </row>
> <row>
> + <entry><constant>V4L2_CID_RSSI_THRESHOLD</constant></entry>
> + <entry>integer</entry>
> + <entry>Set RSSI threshold level. Change the default threshold
> +level used to select valid frequencies during vidioc_s_hw_freq_seek.</entry>
> + </row>
> + <row>
> + <entry><constant>V4L2_CID_TUNE_AF</constant></entry>
> + <entry>integer</entry>
> + <entry>Set Alternative Frequency mode. Enable or disable
> +alternative frequency mode.</entry>
> + </row>
> + <row>
> <entry><constant>V4L2_CID_BLACK_LEVEL</constant></entry>
> <entry>integer</entry>
> <entry>Another name for brightness (not a synonym of

Sorry, but, I doubt that any userspace application developer will find those descriptions
useful.

For the threshold: I understand that this is the carrier strength used to detect a
channel, right? If so, please improve the description.
Also, The better is to associate its scale to a carrier level in some unit like dB.

The second control means absolutely nothing... It is not a boolean value, and what
is "alternative" frequency mode?

Cheers,
Mauro.



\
 
 \ /
  Last update: 2010-12-03 13:17    [from the cache]
©2003-2011 Jasper Spaans