lkml.org 
[lkml]   [2010]   [Dec]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 8/8] fs: add i_op->sync_inode
 - the sync_inodes_sb export removal looks fine to, but should be a
separate patch with a good changelog
- why is the sync_inode_metadata wait parameter removed? Especially
as we would need it for some callers that need to be converted to it.
E.g. in this patch converts writeback_inode from non-blocking to
blocking behaviour.
- except for that the sync_inode() removal is fine, I had planned for
that already. But again, please a separate and well-documented
patch.

As for the actualy sync_inode operation: I don't think it's helpful.
The *_sync_inode helpers in ext2 and fat are fine, but there's little
point in going through an iops vector for it. Also adding the file
syncing really complicates the API for now reason, epecially with
the range interface.



\
 
 \ /
  Last update: 2010-12-29 16:15    [W:1.042 / U:0.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site