Messages in this thread | | | Date | Wed, 29 Dec 2010 14:25:17 +0100 | From | Michal Marek <> | Subject | Re: [PATCH] gen_init_cpio: Avoid race between call to stat() and call to open() |
| |
On Fri, Dec 24, 2010 at 05:33:48PM -0500, Jeff Garzik wrote: > On 12/24/2010 03:28 PM, Jesper Juhl wrote: > >Hi, > > > >In usr/gen_init_cpio.c::cpio_mkfile() a call to stat() is made based on > >pathname, subsequently the file is open()'ed and then the value of the > >initial stat() call is used to allocate a buffer. This is not safe since > >the file may change between the call to stat() and the call to open(). > >Safer to just open() the file and then do fstat() using the filedescriptor > >returned by open. > > > > > >Signed-off-by: Jesper Juhl<jj@chaosbits.net> > > Acked-by: Jeff Garzik <jgarzik@redhat.com>
Looks like an academic issue to me, but the kernel should promote good programming practices :). Applied to kbuild-2.6.git#kbuild, thanks.
Michal
| |