Messages in this thread | | | Date | Wed, 29 Dec 2010 15:37:16 -0800 | Subject | Re: [PATCH 1/6] x86: Change get_max_mapped() to inline | From | Yinghai Lu <> |
| |
On Wed, Dec 29, 2010 at 3:30 PM, Yinghai Lu <yinghai@kernel.org> wrote:
>>> Index: linux-2.6/arch/x86/include/asm/page_types.h >>> =================================================================== >>> --- linux-2.6.orig/arch/x86/include/asm/page_types.h >>> +++ linux-2.6/arch/x86/include/asm/page_types.h >>> @@ -45,6 +45,11 @@ extern int devmem_is_allowed(unsigned lo >>> extern unsigned long max_low_pfn_mapped; >>> extern unsigned long max_pfn_mapped; >>> >>> +static inline u64 get_max_mapped(void) >>> +{ >>> + return (u64)max_pfn_mapped<<PAGE_SHIFT; >>> +} >>> + >>> extern unsigned long init_memory_mapping(unsigned long start, >>> unsigned long end); >>> >> > >> Furthermore, it seems to me that it would make more >> sense for this to be phys_addr_t instead of u64; would you agree? > > yes.
or could just use unsigned long instead.
on 32bit it will be under 4g on 64bit unsigned long is 64bit already.
Thanks
Yinghai -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |