lkml.org 
[lkml]   [2010]   [Dec]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH][Trivial] sound, ca0106: Fix assignment to 'channel'.
On Fri, 24 Dec 2010, Jesper Juhl wrote:

> Hi,
>
> The assignment to the local variable 'channel' in
> snd_ca0106_pcm_pointer_capture() is a little crazy.
> Order of assignment is undefined. This fixes it.
>
> Signed-off-by: Jesper Juhl <jj@chaosbits.net>
> ---
> ca0106_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/sound/pci/ca0106/ca0106_main.c b/sound/pci/ca0106/ca0106_main.c
> index d2d12c0..01b4938 100644
> --- a/sound/pci/ca0106/ca0106_main.c
> +++ b/sound/pci/ca0106/ca0106_main.c
> @@ -1082,7 +1082,7 @@ snd_ca0106_pcm_pointer_capture(struct snd_pcm_substream *substream)
> struct snd_pcm_runtime *runtime = substream->runtime;
> struct snd_ca0106_pcm *epcm = runtime->private_data;
> snd_pcm_uframes_t ptr, ptr1, ptr2 = 0;
> - int channel = channel=epcm->channel_id;
> + int channel = epcm->channel_id;
>
> if (!epcm->running)
> return 0;
>

As this doesn't seem to be present in linux-next as of today, I have
picked it up for trivial queue. Thanks,

--
Jiri Kosina
SUSE Labs, Novell Inc.


\
 
 \ /
  Last update: 2010-12-27 15:13    [W:0.036 / U:2.264 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site