lkml.org 
[lkml]   [2010]   [Dec]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 2/3] spi_topcliff_pch: change calling function order correctly in remove
    Date
    Signed-off-by: Tomoya MORINAGA <tomoya-linux@dsn.okisemi.com>
    ---
    drivers/spi/spi_topcliff_pch.c | 10 +++++-----
    1 files changed, 5 insertions(+), 5 deletions(-)

    diff --git a/drivers/spi/spi_topcliff_pch.c b/drivers/spi/spi_topcliff_pch.c
    index 18e077b..a796eaf 100644
    --- a/drivers/spi/spi_topcliff_pch.c
    +++ b/drivers/spi/spi_topcliff_pch.c
    @@ -1166,21 +1166,21 @@ static void pch_spi_remove(struct pci_dev *pdev)
    spin_unlock(&board_dat->data[i]->lock);
    }

    - /* Free resources allocated for PCH SPI */
    - pch_spi_free_resources(board_dat);
    -
    /* Unregister SPI master */
    for (i = 0; i < board_dat->num; i++)
    spi_unregister_master(board_dat->data[i]->master);

    - /* free memory for private data */
    - kfree(board_dat);
    + /* Free resources allocated for PCH SPI */
    + pch_spi_free_resources(board_dat);

    pci_set_drvdata(pdev, NULL);

    /* disable PCI device */
    pci_disable_device(pdev);

    + /* free memory for private data */
    + kfree(board_dat);
    +
    dev_dbg(&pdev->dev, "%s invoked pci_disable_device\n", __func__);
    }

    --
    1.6.0.6


    \
     
     \ /
      Last update: 2010-12-27 12:29    [W:2.161 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site