lkml.org 
[lkml]   [2010]   [Dec]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [cpuops cmpxchg double V1 1/4] Generic support for this_cpu_cmpxchg_double
On Sat, Dec 25, 2010 at 05:55:22PM -0600, Christoph Lameter wrote:
> On Sat, 25 Dec 2010, Tejun Heo wrote:
>
> > ABI. But that said, it might still be problematic on other
> > architectures when we try to apply it to different architectures. Is
> > everyone against just taking a scalar for the first variable instead
> > of taking a pointer? I'd be happier with that than the current one.
>
> How about replacing that with two scalars? Macro will check that the
> scalaers are properly aligned and that the second follows the first. Then
> there is also better symmetry in the parameters.
>
> bool this_cpu_cmpxchg_double(
> percpu_1, percpu_2
> old_1, old_2
> new_1, new_2
> )

Yeah, maybe. The interface is a bit redundant but probably the most
fool proof. I'm okay with either taking a single scalar or both.

Thanks.

--
tejun


\
 
 \ /
  Last update: 2010-12-27 11:55    [W:0.049 / U:9.788 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site