lkml.org 
[lkml]   [2010]   [Dec]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] mct_u232: added _ioctl, _msr_to_icount and _get_icount functions
On Mon, 27 Dec 2010 12:55:38 -0800 (PST)
Tsozik <tsozik@yahoo.com> wrote:

> +static void mct_u232_msr_to_icount(struct async_icount *icount,
> + unsigned char msr)
> +{
> + /* Translate Control Line states */
> + if (msr & MCT_U232_MSR_DDSR)
> + icount->dsr++;
> + if (msr & MCT_U232_MSR_DCTS)
> + icount->cts++;
> + if (msr & MCT_U232_MSR_DRI)
> + icount->rng++;
> + if (msr & MCT_U232_MSR_DCD)
> + icount->dcd++;
> +} /* mct_u232_msr_to_icount */

This looks good to me, but since it's a new hardware facility that
we did not use previously, I'd like to make sure this works for you.

> mct_u232_msr_to_icount uses delta nibble to track state changes.
> RM-60 testing showed the same levels as measured by PDM-2 in close
> proximity to RM-60.

Right, this is good. I have just one request for you: could you find
somewhere a computer with a built-in 8250-compatible serial port,
attach RM-60 to it, and run your counting application there?
I think your patch looks just fine, but I would like to make sure
that we (e.g. mct_u232+patch) are truly compatible now.

-- Pete


\
 
 \ /
  Last update: 2010-12-27 23:15    [W:0.058 / U:2.228 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site