lkml.org 
[lkml]   [2010]   [Dec]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] HID: picolcd: fix misuse of logical operation in place of bitop
Thanks for spotting,

Acked-by: Bruno Prémont <bonbons@linux-vserver.org>

On Mon, 27 December 2010 David Sterba <dsterba@suse.cz> wrote:
> CC: Bruno Prémont <bonbons@linux-vserver.org>
> CC: Jiri Kosina <jkosina@suse.cz>
> Signed-off-by: David Sterba <dsterba@suse.cz>
> ---
> drivers/hid/hid-picolcd.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hid/hid-picolcd.c b/drivers/hid/hid-picolcd.c
> index bc2e077..0aff3cd 100644
> --- a/drivers/hid/hid-picolcd.c
> +++ b/drivers/hid/hid-picolcd.c
> @@ -1544,7 +1544,7 @@ static ssize_t picolcd_debug_eeprom_read(struct file *f, char __user *u,
>
> /* prepare buffer with info about what we want to read (addr & len) */
> raw_data[0] = *off & 0xff;
> - raw_data[1] = (*off >> 8) && 0xff;
> + raw_data[1] = (*off >> 8) & 0xff;
> raw_data[2] = s < 20 ? s : 20;
> if (*off + raw_data[2] > 0xff)
> raw_data[2] = 0x100 - *off;
> @@ -1583,7 +1583,7 @@ static ssize_t picolcd_debug_eeprom_write(struct file *f, const char __user *u,
>
> memset(raw_data, 0, sizeof(raw_data));
> raw_data[0] = *off & 0xff;
> - raw_data[1] = (*off >> 8) && 0xff;
> + raw_data[1] = (*off >> 8) & 0xff;
> raw_data[2] = s < 20 ? s : 20;
> if (*off + raw_data[2] > 0xff)
> raw_data[2] = 0x100 - *off;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2010-12-27 22:51    [W:0.171 / U:0.184 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site