Messages in this thread Patch in this message | | | Date | Sat, 25 Dec 2010 19:01:05 +0100 (CET) | From | Jesper Juhl <> | Subject | [PATCH] Ceph: Fix use-after-free in destroy_fs_client() |
| |
Hi,
In fs/ceph/super.c::destroy_fs_client() the pointer 'fsc' is freed by kfree() and subsequently used in a call to dout() - use after free bug. Easily fixed by simply moving the kfree() call after the dout() call.
Signed-off-by: Jesper Juhl <jj@chaosbits.net> --- super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ceph/super.c b/fs/ceph/super.c index 08b460a..7373594 100644 --- a/fs/ceph/super.c +++ b/fs/ceph/super.c @@ -498,8 +498,8 @@ void destroy_fs_client(struct ceph_fs_client *fsc) ceph_destroy_client(fsc->client); - kfree(fsc); dout("destroy_fs_client %p done\n", fsc); + kfree(fsc); } /*
-- Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/ Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please.
| |