Messages in this thread | | | Date | Fri, 24 Dec 2010 21:40:08 +0100 (CET) | From | Jesper Juhl <> | Subject | Re: [PATCH][RFC] HPFS: Don't use pointer to out-of-scope array |
| |
On Fri, 24 Dec 2010, Andreas Schwab wrote:
> Jesper Juhl <jj@chaosbits.net> writes: > > > Secondly I fail to see how this code inside the while loop can even work: > > > > if (hpfs_ea_read(s, a, ano, pos + 4, ea->namelen + 1 + (ea->indirect ? 8 : 0), ex + 4)) > > > > There is nothing initializing 'ex' which 'ea' points to, so > > 'ea->namelen' and 'ea->indirect' are uninitialized. > > The preceding hpfs_ea_read should do it (it reads the first 4 bytes of > ex which aliases ea->namelen and ea->indirect). > How I managed to miss that I don't know, but I did and you are correct. Thanks.
-- Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/ Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please.
| |