Messages in this thread | | | Date | Thu, 23 Dec 2010 12:03:15 -0700 | From | Grant Likely <> | Subject | Re: [PATCH 2/2] spi_imx.c: TRIVIAL mx25 & mx35 SPI_VER is 0.7 |
| |
On Thu, Dec 23, 2010 at 03:29:34PM +0100, Uwe Kleine-König wrote: > On Thu, Dec 23, 2010 at 12:12:10PM +0100, Richard Genoud wrote: > > The check on cpu_is_mx25 and cpu_is_mx35 was made twice. > > This is obviously wrong. > obviously wrong but no wrong behaviour. Your patch only makes the code > consistent, but IMHO it doesn't qualify as a bugfix. > > > Anyway, this patch won't change the previous behaviour which is > > SPI_IMX_VER_0_7 for mx25 and mx35. > This conflicts with > http://mid.gmane.org/1290589546-21662-1-git-send-email-u.kleine-koenig@pengutronix.de > > which I prefer. The platform IDs have it correct (i.e. > > imx25-cspi -> 0.7 > imx31-cspi -> 0.4 > imx35-cspi -> 0.7 > > )
Oops, missed you're reply. Okay, I've dropped Richard's patch and will look at yours.
g.
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |