Messages in this thread | | | Date | Wed, 22 Dec 2010 10:33:41 +0100 | From | Tejun Heo <> | Subject | Re: [V3 PATCH] kthread_work: Make lockdep happy |
| |
On Wed, Dec 22, 2010 at 11:23:05AM +0800, Yong Zhang wrote: > From: Yong Zhang <yong.zhang0@gmail.com> > Subject: [V3 PATCH] kthread_work: Make lockdep happy > > spinlock in kthread_worker and wait_queue_head in kthread_work > both should be lockdep sensible. > So change the interface to make it suiltable for CONFIG_LOCKDEP. > > Reported-by: Nicolas <nicolas.mailhot@laposte.net> > Signed-off-by: Yong Zhang <yong.zhang0@gmail.com> > Signed-off-by: Andy Walls <awalls@md.metrocast.net> > Tested-by: Andy Walls <awalls@md.metrocast.net> > Cc: Tejun Heo <tj@kernel.org> > Cc: Andrew Morton <akpm@linux-foundation.org>
Applied with the following comment update (because the term "special work" was a bit too confusing given the context) to wq#for-linus. Will push out to Linus in several days.
+/* + * kthread_worker.lock and kthread_work.done need their own lockdep class + * keys if they are defined on stack with lockdep enabled. Use the + * following macros when defining them on stack. + */
Thank you.
-- tejun
| |