Messages in this thread | | | Subject | Re: [patch 2/3] add new macros to make percpu readmostly section correctly align | From | Shaohua Li <> | Date | Thu, 23 Dec 2010 10:38:34 +0800 |
| |
On Mon, 2010-12-20 at 23:55 +0800, Tejun Heo wrote: > Hello, > > On 12/20/2010 02:28 AM, Shaohua Li wrote: > >> Not being able to cross build every arch is okay but you at least need > >> to make an effort to make things easily applicable to other archs and > >> avoid adding subtle ugliness like the above. Please at least try to > >> look at other arch codes and see how things can be made to work across > >> different archs. Setting up cross compilers for the major archs, for > >> example, sparc, power and ia64 isn't that difficult either. > > > > This still needs I fix every arch, for example, as Sam pointed out, > > spark build will fail. I really have the bandwidth and capability to do > > this. Increment changes are always preferred. My original patch is > > trying to follow increment changes way. > > Yeah, well, in my experience, those approaches usually just end up > piling partial conversions on top of different set of partial > conversions. It's not like we're talking about a major arch dependent > feature it's just a matter of looking through different arch codes, > maybe test building some, pushing things to linux-next and dealing > with fallouts if there is any. I'll try to do it myself. Thanks for doing it and sorry I didn't do it. The first patch in the series isn't related to this issue, please consider merge it.
Thanks, Shaohua
| |