Messages in this thread | | | Date | Wed, 22 Dec 2010 17:39:40 -0800 | Subject | Re: [PATCH] dmaengine: provide dummy functions for DMA_ENGINE=n | From | Dan Williams <> |
| |
On Wed, Dec 22, 2010 at 4:13 PM, Guennadi Liakhovetski <g.liakhovetski@gmx.de> wrote: > On Wed, 22 Dec 2010, Dan Williams wrote: > >> On Wed, Dec 22, 2010 at 5:46 AM, Guennadi Liakhovetski >> <g.liakhovetski@gmx.de> wrote: >> > This lets drivers, optionally using the dmaengine, build with DMA_ENGINE >> > unselected. >> > >> > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de> >> > --- >> > include/linux/dmaengine.h | 13 ++++++++++--- >> > 1 files changed, 10 insertions(+), 3 deletions(-) >> >> Is this fixing build errors, or is this just relieving drivers from >> needing to surround calls to dma_{request|release}_channel() with >> ifdef CONFIG_DMA_ENGINE? The former makes this more urgent, the >> latter can wait for the next merge window. > > sh_mmcif.c doesn't compile, if configured for DMA, but DMA_ENGINE is > unselected. So, yes, this wants to be fixed. But there's more than one way > to fix it. I've chosen this one, as it seems more generic to me. >
Yes, it's the right fix. I was just trying to see if it needs to go in now and if there were any implications for -stable. Unless I am missing something drivers/mmc/host/sh_mmcif.c does not even include dmaengine.h today so this can wait until the 2.6.38 window.
-- Dan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |