lkml.org 
[lkml]   [2010]   [Dec]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3] rtc-cmos: fix suspend/resume
On Sun, 19 Dec 2010 19:08:28 +0000 (GMT)
Daniel Drake <dsd@laptop.org> wrote:

> From: Paul Fox <pgf@laptop.org>
>
> rtc-cmos was setting suspend/resume hooks at the device_driver level.
> However, the platform bus code (drivers/base/platform.c) only looks
> for resume hooks at the dev_pm_ops level, or within the platform_driver.
>
> Switch rtc_cmos to use dev_pm_ops so that suspend/resume code is
> executed again.
>
> Signed-off-by: Paul Fox <pgf@laptop.org>
> Signed-off-by: Daniel Drake <dsd@laptop.org>
> ---
> drivers/rtc/rtc-cmos.c | 16 +++++++++-------
> 1 files changed, 9 insertions(+), 7 deletions(-)
>
> v2: incorporate feedback from Rafael J. Wysocki, fix tabs, make a bit more
> consistent with typical SIMPLE_DEV_PM_OPS users.
>
> v3: remove const keyword already set by macro, thanks to Rafael

It's unclear what the user-visible effects of this bug were. Machine
fails to suspend? RTC loses its brains on resume? Something else?

That's really important information for a bugfix's changelog. Please
never omit it.



I'm going to assume that whatever-the-behaviour-is is fairly serious,
and that we want this patch in 2.6.37. So I tagged it for backporting
into 2.6.37.1, as we're getting pretty close to 2.6.37.

The patch also applies to 2.6.36. Is it needed there? And in earlier
kernels?



\
 
 \ /
  Last update: 2010-12-22 23:23    [W:0.758 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site