lkml.org 
[lkml]   [2010]   [Dec]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
SubjectRe: [Xen-devel] Re: [PATCH 04/10] xen/mmu: For 1-1 mapping, automatically set _PAGE_IOMAP.
From
Date
On Wed, 2010-12-22 at 15:02 +0000, Konrad Rzeszutek Wilk wrote:
> On Tue, Dec 21, 2010 at 02:29:31PM -0800, Jeremy Fitzhardinge wrote:
> > On 12/21/2010 01:37 PM, Konrad Rzeszutek Wilk wrote:
> > > @@ -832,6 +832,9 @@ static pteval_t pte_pfn_to_mfn(pteval_t val)
> > > pteval_t flags = val & PTE_FLAGS_MASK;
> > > unsigned long mfn = pfn_to_mfn(pfn);
> > >
> > > + if (mfn == pfn)
> > > + flags |= _PAGE_IOMAP;
> >
> > Why? Does it really make sense to set _PAGE_IOMAP if they just happen
> > to be the same value?
>
> Yes. Without this, user applications, such as 'dmidecode' cannot get
> data.

I think Jeremy's point is that the "mfn == pfn" here has false
positives, since it is possible that a normal RAM page has identical mfn
and pfn by pure chance.

Ian.



\
 
 \ /
  Last update: 2010-12-22 17:31    [W:0.127 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site