Messages in this thread | | | Date | Wed, 22 Dec 2010 13:25:35 +0000 | From | Mark Brown <> | Subject | Re: [PATCH v2 2/6] MFD MAX8998/LP3974: Support LP3974 RTC |
| |
On Wed, Dec 22, 2010 at 03:23:07PM +0900, MyungJoo Ham wrote:
> before reading it. If the device name is "lp3974-regerr", the rtc driver > assumes that such delays are required. If the device name is "lp3974", > the rtc driver does not. Although we have not seen LP3974s without > requiring such delays, we assume that such LP3974s will be released > soon (or they have done so already) and they are supported by "lp3974".
Might a bit of platform data not be a more robust way of passing this in? If we use the device name then it'd be difficult to handle other issues in future.
It's a shame the affected devices can't be identified at runtime :(
| |