Messages in this thread | | | Date | Wed, 22 Dec 2010 02:22:30 +0300 | From | Anton Vorontsov <> | Subject | Re: [PATCH 1/1] power: bq20z75: Update return value of CURRENT NOW |
| |
On Mon, Dec 20, 2010 at 04:54:22PM -0800, rklein wrote: > On Tue, 2010-12-14 at 19:04 -0800, Olof Johansson wrote: > > On Tue, Dec 14, 2010 at 05:01:25PM -0800, rklein wrote: > > > The BQ20Z75 will return a negative value for current if the battery is > > > discharging and a positive value if charging. This should always be > > > exported > > > as a positive number. > > > > > > Signed-off-by: Rhyland Klein <rklein@nvidia.com> > > > > Reviewed-by: Olof Johansson <olof@lixom.net> > > > > -Olof > > Anton, is this patch ok to get put in?
I'm not sure. Probably not. Why would you think that the current should always be positive? For ds2760 it isn't, for example. If some driver assumes always positive current, I think it should be fixed instead.
If the battery is discharging, let it be negative. That's what happens on wires anyway. :-)
-- Anton Vorontsov Email: cbouatmailru@gmail.com
| |