lkml.org 
[lkml]   [2010]   [Dec]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 10/16] ptrace: clean transitions between TASK_STOPPED and TRACED
On Tue, Dec 21, 2010 at 06:31:55PM +0100, Tejun Heo wrote:
> > > @@ -1842,7 +1879,18 @@ static int do_signal_stop(int signr)
> > >
> > > spin_lock_irq(&current->sighand->siglock);
> > > } else
> > > - ptrace_stop(current->exit_code, CLD_STOPPED, 0, NULL);
> > > + ptrace_stop(current->group_stop & GROUP_STOP_SIGMASK,
> > > + CLD_STOPPED, 0, NULL);
> >
> > Perhaps it would be more clean to clear ->exit_code here, in the
> > "else" branch.
>
> Hmmm... and dropping current->exit_code clearing from the
> do_signal_stop(), right? I'm a bit confused about the use of
> current->exit_code tho. Why aren't we clearing it from ptrace_stop()?

Ah, never mind. It's used as the signr return from ptrace signal
trap.

Thanks.

--
tejun


\
 
 \ /
  Last update: 2010-12-21 18:35    [W:0.061 / U:4.552 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site