Messages in this thread | | | Date | Tue, 21 Dec 2010 02:27:44 +0100 | From | Frederic Weisbecker <> | Subject | Re: [RFC PATCH 10/15] nohz_task: Enter in extended quiescent state when in userspace |
| |
On Mon, Dec 20, 2010 at 05:18:40PM +0100, Peter Zijlstra wrote: > On Mon, 2010-12-20 at 16:24 +0100, Frederic Weisbecker wrote: > > (we check if the local cpu is in nohz mode, which means > > no other task compete on that CPU) > > You keep repeating that definition, but its not true.. It means there is > not work for the tick to do, the tick does _tons_ more besides > preemption, so nr_running==1 is necessary but not sufficient.
Sure but the point is that if the tick is not running, it means that the nohz task is the only task running on that CPU.
Now indeed there are other reasons for the tick to restart like RCU or the effective nohz mode to physically happen or to be delayed, which is decided by tick_nohz_stop_sched_tick().
| |