lkml.org 
[lkml]   [2010]   [Dec]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC PATCH 02/15] nohz_task: Avoid nohz task cpu as non-idle timer target
From
Date
On Mon, 2010-12-20 at 11:06 -0500, Steven Rostedt wrote:
> On Mon, 2010-12-20 at 16:47 +0100, Peter Zijlstra wrote:
> > On Mon, 2010-12-20 at 16:24 +0100, Frederic Weisbecker wrote:
> > > Unbound timers are preferably targeted for non idle cpu. If
> > > possible though, prioritize idle cpus over nohz task cpus,
> > > because the main point of nohz task is to avoid unnecessary
> > > timer interrupts.
> >
> > Oh is it?
> >
> > I'd very much expect the cpu that arms the timer to get the interrupt. I
> > mean, if the task doesn't want to get interrupted by timers,
> > _DON'T_USE_TIMERS_ to begin with.
> >
> > So no, don't much like this at all.
>
> I think this comes from other tasks on other CPUs that are using timers.

Tasks on other CPUs should not cause timers on this CPU, _if_ that does
happen, fix that.

> Although, I'm not sure what causes an "unbound" timer to happen. I
> thought timers usually go off on the CPU that asked for it to go off.

They do, except if you enable some weird power management feature that
migrates timers around so as to let CPUs sleep longer. But I doubt
that's the reason for this here, and if it is, just disable that.



\
 
 \ /
  Last update: 2010-12-20 17:15    [W:0.156 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site