Messages in this thread | | | Date | Fri, 3 Dec 2010 01:48:16 +0300 | From | Cyrill Gorcunov <> | Subject | Re: [RFC] perf: Prevent potential null dereference |
| |
On Thu, Dec 02, 2010 at 08:46:10PM -0200, Arnaldo Carvalho de Melo wrote: ... > > > It seems exit right here is more convenient than passing error > > > handling level up (which would have to exit anyway), thought > > > if handling it "upper" is preferred -- just say a word. > > > > > > > Good. > > > > As a nit, not that it matters that much because we are very close to the starting code > > anyway, but it would be better to propagate the error to the callers. > > I'm of the opinion that main() should be where exit() is allowed, and > even there... return would be better. 8-) > > - Arnaldo >
ok, i'll update tomorrow (almost off).
Cyrill
| |