lkml.org 
[lkml]   [2010]   [Dec]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC] perf: Prevent potential null dereference
On Thu, Dec 02, 2010 at 08:46:10PM -0200, Arnaldo Carvalho de Melo wrote:
...
> > > It seems exit right here is more convenient than passing error
> > > handling level up (which would have to exit anyway), thought
> > > if handling it "upper" is preferred -- just say a word.
> > >
> >
> > Good.
> >
> > As a nit, not that it matters that much because we are very close to the starting code
> > anyway, but it would be better to propagate the error to the callers.
>
> I'm of the opinion that main() should be where exit() is allowed, and
> even there... return would be better. 8-)
>
> - Arnaldo
>

ok, i'll update tomorrow (almost off).

Cyrill


\
 
 \ /
  Last update: 2010-12-02 23:51    [W:0.057 / U:0.244 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site