lkml.org 
[lkml]   [2010]   [Dec]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/5] HID: roccat: declaring meaning of pack pragma usage in driver headers
On Tue, 30 Nov 2010, Greg KH wrote:

> > > Using pack pragma to prevent padding bytes in binary data structures
> > > used for hardware communication. Explanation of these pragmas was requested.
> > [...]
> >
> > It would be clearer to use the '__packed' macro after each structure
> > definition instead of using this awful Microsoft extension.
>
> I agree, that's the "normal" Linux way of doing things.
>
> Other than that, this patch set looks good to me. Jiri, if the packed
> change is made, do you want me to take these through my tree, or do you
> want to take them through yours? Whatever is easier for you is fine
> with me.

Hi Greg,

as this is part of larger roccat patchset, I will be processing it through
my tree once completely reviewed.

Thanks,

--
Jiri Kosina
SUSE Labs, Novell Inc.


\
 
 \ /
  Last update: 2010-12-02 16:07    [W:0.056 / U:1.904 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site