Messages in this thread | | | Date | Thu, 2 Dec 2010 16:04:35 +0100 (CET) | From | Jiri Kosina <> | Subject | Re: [PATCH 3/5] HID: roccat: declaring meaning of pack pragma usage in driver headers |
| |
On Tue, 30 Nov 2010, Greg KH wrote:
> > > Using pack pragma to prevent padding bytes in binary data structures > > > used for hardware communication. Explanation of these pragmas was requested. > > [...] > > > > It would be clearer to use the '__packed' macro after each structure > > definition instead of using this awful Microsoft extension. > > I agree, that's the "normal" Linux way of doing things. > > Other than that, this patch set looks good to me. Jiri, if the packed > change is made, do you want me to take these through my tree, or do you > want to take them through yours? Whatever is easier for you is fine > with me.
Hi Greg,
as this is part of larger roccat patchset, I will be processing it through my tree once completely reviewed.
Thanks,
-- Jiri Kosina SUSE Labs, Novell Inc.
| |