[lkml]   [2010]   [Dec]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [RFC 1/5] drop page reference on remove_from_page_cache
    On Sat, 18 Dec 2010 02:13:36 +0900
    Minchan Kim <> wrote:

    > Now we add page reference on add_to_page_cache but doesn't drop it
    > in remove_from_page_cache. Such asymmetric makes confusing about
    > page reference so that caller should notice it and comment why they
    > release page reference. It's not good API.
    > Long time ago, Hugh tried it[1] but gave up of reason which
    > reiser4's drop_page had to unlock the page between removing it from
    > page cache and doing the page_cache_release. But now the situation is
    > changed. I think at least things in current mainline doesn't have any
    > obstacles. The problem is fs or somethings out of mainline.
    > If it has done such thing like reiser4, this patch could be a problem.
    > Do anyone know the such things? Do we care about things out of mainline?
    > Note :
    > The comment of remove_from_page_cache make by copy & paste & s/swap/page/
    > from delete_from_swap_cache.
    > [1]
    > Cc: Hugh Dickins <>
    > Cc:
    > Signed-off-by: Minchan Kim <>

    I like this.
    Reviewd-by: KAMEZAWA Hiroyuki <>

     \ /
      Last update: 2010-12-20 03:01    [W:0.024 / U:8.292 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site