Messages in this thread | | | Date | Sat, 18 Dec 2010 15:51:35 +0100 | From | Tejun Heo <> | Subject | Re: [cpuops cmpxchg double V1 1/4] Generic support for this_cpu_cmpxchg_double |
| |
On 12/18/2010 03:47 PM, Tejun Heo wrote: > This is ugly. :-( I think we should have made this_cpu_*() ops take > pointers from the beginning. Anyways, that's too late, so is it > completely impossible to make cmpxchg_double's take a scalar value? > It can take the pointer all the same, no?
Also, the ratonale behind taking a scalar value instead of pointer was that the operation changes what they do depending on the type of the parameter (the size of the parameter), which is true for the double ops too, so I think it would be better if we stick with lvalues.
Thanks.
-- tejun
| |