lkml.org 
[lkml]   [2010]   [Dec]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 1/2 V3] applesmc: Use PnP rather than hardcoding resources and devices
    On Fri, Dec 17, 2010 at 08:23:21PM -0800, Guenter Roeck wrote:
    > On Fri, Dec 17, 2010 at 05:24:20PM -0500, Matthew Garrett wrote:
    > > The AppleSMC device is described in ACPI, including a list of its resources.
    > > We should use those rather than hardcoding the ports. A side-effect is that
    > > we can then remove the DMI matching, since there's a unique identifier to
    > > indicate that the machine has one of these devices.
    > >
    > > Signed-off-by: Matthew Garrett <mjg@redhat.com>
    >
    > You added a whitespace error, and kfree() is safe and doesn't need a check.
    > I fixed those, so no need to resubmit. If Henrik gives his Ack we are ready to go.

    Thanks, I will give it some testing before doing so. Matthew, did you
    test this under EFI boot? Also, NOTIFICATION_KEY does not seem to be
    used anywhere.

    Henrik


    \
     
     \ /
      Last update: 2010-12-18 10:11    [W:0.042 / U:29.432 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site