lkml.org 
[lkml]   [2010]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC] Align tegra-ehci DMA transfers to 32B
On Fri, Dec 17, 2010 at 01:58:47PM -0800, Robert Morell wrote:
> This small set of patches fixes an issue where DMA from the tegra EHCI
> controller could be corrupted. It was most commonly seen with USB network
> adapters, though in theory it could happen with any USB traffic.
>
> (Note: An attempt was made to fix this with commit 367c3aab, which set
> NET_IP_ALIGN to 0 and NET_SKB_PAD to 32. Unfortunately, not all network
> drivers honor them (presumably since these are intended as optimizations rather
> than hard rules). This does mean that properly-written network drivers should
> fall through this code with very little overhead, however.)

We don't have many USB network drivers, why not just fix them up to
handle this properly, then you will not need to change any core USB
code, right?

thanks,

greg k-h


\
 
 \ /
  Last update: 2010-12-17 23:35    [from the cache]
©2003-2011 Jasper Spaans