Messages in this thread | | | Date | Fri, 17 Dec 2010 20:22:19 +0000 | From | "Serge E. Hallyn" <> | Subject | Re: [RFC 4/5] user namespaces: allow killing tasks in your own or child userns |
| |
Quoting Eric W. Biederman (ebiederm@xmission.com): > >> > cred = current_cred(); > >> > tcred = __task_cred(t); > >> Nit pick you don't need to compute cred and tcred here now. > > > > Just to make sure I understand right: you mean wait until after the > > same_thread_group() check to save calculation in that case, right? > > I mean cred and tcred are only use in kill_ok_by_cred. > So we can eliminate those two variables from check_kill_permission.
D'oh. Should've looked at the original tree, not the context. Got it, thanks.
-serge
| |