lkml.org 
[lkml]   [2010]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 14/15] GFS2: fsck.gfs2 reported statfs error after gfs2_grow
    Date
    From: Bob Peterson <rpeterso@redhat.com>

    When you do gfs2_grow it failed to take the very last
    rgrp into account when adding up the new free space due
    to an off-by-one error. It was not reading the last
    rgrp from the rindex because of a check for "<=" that
    should have been "<". Therefore, fsck.gfs2 was finding
    (and fixing) an error with the system statfs file.

    Signed-off-by: Bob Peterson <rpeterso@redhat.com>

    diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c
    index 25dbe5c..7293ea2 100644
    --- a/fs/gfs2/rgrp.c
    +++ b/fs/gfs2/rgrp.c
    @@ -500,7 +500,7 @@ u64 gfs2_ri_total(struct gfs2_sbd *sdp)
    for (rgrps = 0;; rgrps++) {
    loff_t pos = rgrps * sizeof(struct gfs2_rindex);

    - if (pos + sizeof(struct gfs2_rindex) >= i_size_read(inode))
    + if (pos + sizeof(struct gfs2_rindex) > i_size_read(inode))
    break;
    error = gfs2_internal_read(ip, &ra_state, buf, &pos,
    sizeof(struct gfs2_rindex));
    --
    1.7.3.3


    \
     
     \ /
      Last update: 2010-12-17 13:51    [W:0.020 / U:29.232 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site