Messages in this thread | | | Date | Thu, 16 Dec 2010 15:38:40 +0800 | From | Américo Wang <> | Subject | Re: [PATCH] rculist: fix borked __list_for_each_rcu() macro |
| |
On Thu, Dec 16, 2010 at 07:02:36AM +0100, Mariusz Kozlowski wrote: >On Wed, Dec 15, 2010 at 03:20:05PM -0800, Paul E. McKenney wrote: >> On Wed, Dec 15, 2010 at 11:11:12PM +0100, Mariusz Kozlowski wrote: >> > This restores parentheses blance. >> >> Good catch, queued!!! >> >> This does not actually appear to be in use anywhere in the kernel any >> more, so I queued this for 2.6.38 rather than in the 2.6.37 urgent queue. >> So, just out of curiosity, how did you find this one? > >Some years ago I wrote a dumb script that walks trees of () and {}. >It catches unbalanced trees. It's dumb enough to fail with #ifdef etc, >but most of the time it does its job. It reaches unreachable code >and unused one too. >
gcc will complain about this, however, in this case, it is used.
| |