Messages in this thread | | | Date | Thu, 16 Dec 2010 09:52:02 +0800 | Subject | Re: [PATCH] regulator: Allow modular build of mc13xxx-core | From | Yong Shen <> |
| |
Hi there,
My bad. My test did not cover module-build case. Thanks for fixing this.
Yong
On Thu, Dec 16, 2010 at 5:30 AM, Liam Girdwood <lrg@slimlogic.co.uk> wrote: > On Wed, 2010-12-15 at 14:10 +0000, Mark Brown wrote: >> Since the MFD core for this device and the regulator drivers for these >> devices can be built modular we should also support modular build of >> the shared code for the regulator drivers, otherwise we try to link >> built in code against modular code with unfortunate results. >> >> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com> > > Thanks Mark ! > > It looks like you sent the wrong patch as I had to also add :- > > diff --git a/drivers/regulator/mc13xxx-regulator-core.c b/drivers/regulator/mc13xxx-regulator-core.c > index da46b3c..f53d31b 100644 > --- a/drivers/regulator/mc13xxx-regulator-core.c > +++ b/drivers/regulator/mc13xxx-regulator-core.c > @@ -89,6 +89,7 @@ int mc13xxx_regulator_list_voltage(struct regulator_dev *rdev, > > return mc13xxx_regulators[id].voltages[selector]; > } > +EXPORT_SYMBOL_GPL(mc13xxx_regulator_list_voltage); > > int mc13xxx_get_best_voltage_index(struct regulator_dev *rdev, > int min_uV, int max_uV) > @@ -232,6 +233,7 @@ int mc13xxx_sw_regulator_is_enabled(struct regulator_dev *rdev) > { > return 1; > } > +EXPORT_SYMBOL_GPL(mc13xxx_sw_regulator_is_enabled); > > MODULE_LICENSE("GPL v2"); > MODULE_AUTHOR("Yong Shen <yong.shen@linaro.org>"); > > To get it all building. > > Now applied and squashed with above. > > Liam > -- > Freelance Developer, SlimLogic Ltd > ASoC and Voltage Regulator Maintainer. > http://www.slimlogic.co.uk > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |