lkml.org 
[lkml]   [2010]   [Dec]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [patch 2/3] add new macros to make percpu readmostly section correctly align
    From
    Date
    On Wed, 2010-12-15 at 22:49 +0800, Tejun Heo wrote:
    > Hello,
    >
    > On 12/15/2010 03:08 PM, Tejun Heo wrote:
    > >> +#ifdef INTERNODE_CACHE_BYTES
    > >> +#define INTERNODE_CACHEALIGNED \
    > >> + . = ALIGN(INTERNODE_CACHE_BYTES);
    > >> +#else
    > >> +#define INTERNODE_CACHEALIGNED
    > >> +#endif
    > >
    > > Yeah, this looks good.
    >
    > Just one more thing. If you look at various arch linker scripts,
    > cache line size is always present. After all, RW_DATA_SECTION() needs
    > it. They're different define's or sometimes hardcoded values but it
    > would be nice if we can take this chance to unify them and use it for
    > this too. Would you be interested in doing that?
    might not, sorry.



    \
     
     \ /
      Last update: 2010-12-16 01:57    [W:0.043 / U:0.292 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site