Messages in this thread | | | Date | Wed, 15 Dec 2010 10:42:50 +0800 | Subject | Re: [PATCH] bttv: fix mutex use before init | From | Dave Young <> |
| |
On Wed, Dec 15, 2010 at 5:43 AM, Brandon Philips <brandon@ifup.org> wrote: > On 21:56 Tue 14 Dec 2010, Torsten Kaiser wrote: >> On Tue, Dec 14, 2010 at 1:30 AM, Brandon Philips <brandon@ifup.org> wrote: >> > On 17:13 Sun 12 Dec 2010, Torsten Kaiser wrote: >> >> * change &fh->cap.vb_lock in bttv_open() AND radio_open() to >> >> &btv->init.cap.vb_lock >> >> * add a mutex_init(&btv->init.cap.vb_lock) to the setup of init in bttv_probe() >> > >> > That seems like a reasonable suggestion. An openSUSE user submitted this >> > bug to our tracker too. Here is the patch I am having him test. >> > >> > Would you mind testing it? >> >> No. :-) >> >> Without this patch (==vanilla 2.6.37-rc5) I got 2 more OOPSe by >> restarting hal around 20 times. >> After applying this patch, I did not see a single OOPS after 100 restarts. >> So it looks like the fix is correct. > > Dave, Torsten- Great thanks for testing, can I get both you and Dave's > Tested-by then?
Feel free to add my tested-by line for this, Thanks
> > Mauro- can you please pick up this patch? > > Cheers, > > Brandon >
-- Regards dave -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |