lkml.org 
[lkml]   [2010]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [PATCH 1/1] hv: Use only one receive buffer per channel and kmalloc on initialize
    Date


    > -----Original Message-----
    > From: Jesper Juhl [mailto:jj@chaosbits.net]
    > Sent: Monday, December 13, 2010 3:51 PM
    > To: Ky Srinivasan
    > > > + shut_txf_buf = kmalloc(PAGE_SIZE, GFP_ATOMIC);
    > > > + time_txf_buf = kmalloc(PAGE_SIZE, GFP_ATOMIC);
    > > > + hbeat_txf_buf = kmalloc(PAGE_SIZE, GFP_ATOMIC);
    > > Why are these allocations GFP_ATOMIC. Clearly this is in module
    > loading context and you can afford to sleep. GFP_KERNEL should be fine.
    > >
    >
    > I actually also noticed this when I did my first review of the patch,
    > but
    > I didn't point it out since I thought that "there must be a good
    > reason".
    > But now that you point it out and I look at the code once more I can't
    > actually think of a "good reason",, so I agree with you completely that
    > these should just be GFP_KERNEL.

    I was looking at some of the back code to make sure it is okay, and I see
    No reason not make this change either. I will change it and resubmit.

    Thanks,

    Hank.



    \
     
     \ /
      Last update: 2010-12-14 01:13    [W:0.032 / U:1.424 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site