lkml.org 
[lkml]   [2010]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V2 -next] cs5535: fix printk format warnings
On 12/13/10 12:28, Joe Perches wrote:
> Use vsprintf extension %pR to format resource.
>
> Original-patch-by: Randy Dunlap <randy.dunlap@oracle.com>
> Signed-off-by: Joe Perches <joe@perches.com>
>
> ---
>
> drivers/gpio/cs5535-gpio.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/cs5535-gpio.c b/drivers/gpio/cs5535-gpio.c
> index b566fd5e..d7da7a1 100644
> --- a/drivers/gpio/cs5535-gpio.c
> +++ b/drivers/gpio/cs5535-gpio.c
> @@ -266,8 +266,7 @@ static int __devinit cs5535_gpio_probe(struct platform_device *pdev)
> cs5535_gpio_chip.pdev = pdev;
> spin_lock_init(&cs5535_gpio_chip.lock);
>
> - dev_info(&pdev->dev, "region 0x%x - 0x%x reserved\n",
> - res->start, res->end);
> + dev_info(&pdev->dev, "reserved resource region %pR\n", res);
>
> /* mask out reserved pins */
> mask &= 0x1F7FFFFF;
>
>


OK. How about similar patch for the other warnings:

drivers/misc/cs5535-mfgpt.c:320: warning: format '%x' expects type 'unsigned int', but argument 3 has type 'resource_size_t'
drivers/misc/cs5535-mfgpt.c:320: warning: format '%x' expects type 'unsigned int', but argument 4 has type 'resource_size_t'

--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***


\
 
 \ /
  Last update: 2010-12-13 21:45    [W:0.383 / U:0.240 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site