lkml.org 
[lkml]   [2010]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v3 4/5] msm: hotplug: support cpu hotplug on msm
From
On 13 December 2010 15:12, Catalin Marinas <catalin.marinas@arm.com> wrote:
> On 13 December 2010 01:20,  <ykaoua@qualcomm.com> wrote:
>> --- /dev/null
>> +++ b/arch/arm/mach-msm/hotplug.c
> [...]
>> +static inline void platform_do_lowpower(unsigned int cpu)
>> +{
>> +       /* Just enter wfe for now. */
>> +       for (;;) {
>> +               asm("wfe");
>> +               if (pen_release == cpu) {
>> +                       /*
>> +                        * OK, proper wakeup, we're done
>> +                        */
>> +                       break;
>> +               }
>> +               smp_rmb();
>
> Do you need some barrier after wfe?

I checked with the hw people and it looks like we don't need a DSB
after an WFE (as you have in headsmp.S) since the hardware doesn't
speculate the loads beyond the WFE (lower power state). But in the
above case you may need some compiler barrier to avoid code
reordering.

--
Catalin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2010-12-13 17:55    [W:0.114 / U:0.396 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site