lkml.org 
[lkml]   [2010]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] dlm: sanitize work_start() in lowcomms.c
    Date
    The create_workqueue() returns NULL if failed rather than ERR_PTR().
    Fix error checking and remove unnecessary variable 'error'.

    Signed-off-by: Namhyung Kim <namhyung@gmail.com>
    Cc: Tejun Heo <tj@kernel.org>
    ---
    fs/dlm/lowcomms.c | 16 +++++++---------
    1 files changed, 7 insertions(+), 9 deletions(-)

    diff --git a/fs/dlm/lowcomms.c b/fs/dlm/lowcomms.c
    index 37a34c2c622a..ea04e87b8666 100644
    --- a/fs/dlm/lowcomms.c
    +++ b/fs/dlm/lowcomms.c
    @@ -1430,20 +1430,18 @@ static void work_stop(void)

    static int work_start(void)
    {
    - int error;
    recv_workqueue = create_workqueue("dlm_recv");
    - error = IS_ERR(recv_workqueue);
    - if (error) {
    - log_print("can't start dlm_recv %d", error);
    - return error;
    + if (!recv_workqueue) {
    + log_print("can't start dlm_recv");
    + return -ENOMEM;
    }

    send_workqueue = create_singlethread_workqueue("dlm_send");
    - error = IS_ERR(send_workqueue);
    - if (error) {
    - log_print("can't start dlm_send %d", error);
    + if (!send_workqueue) {
    + log_print("can't start dlm_send");
    destroy_workqueue(recv_workqueue);
    - return error;
    + recv_workqueue = NULL;
    + return -ENOMEM;
    }

    return 0;
    --
    1.7.3.3.400.g93cef


    \
     
     \ /
      Last update: 2010-12-13 16:39    [W:0.025 / U:0.500 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site