Messages in this thread | | | Subject | Re: [PATCH 09/30] sound: don't use flush_scheduled_work() | From | Liam Girdwood <> | Date | Mon, 13 Dec 2010 13:29:03 +0000 |
| |
On Mon, 2010-12-13 at 09:34 +0100, Takashi Iwai wrote: > At Sun, 12 Dec 2010 12:40:41 +0000, > Mark Brown wrote: > > > > On Sun, Dec 12, 2010 at 01:38:36PM +0100, Takashi Iwai wrote: > > > > > Meanwhile, I wondered whether it's the really wanted behavior for > > > that particular code path, thus the previous question to Liam. > > > > Yes, it's desired behaviour. That's what the old code was trying to do. > > OK, now I merged to sound git tree. > Also it's merged back to topic/asoc branch with a conflict fix. > Please pull appropriately. > > (I still don't remember why it had to be flush_work_sync() instead > of cancel_work_sync() in the remove callback path for ASoC, though... > Both aren't so much different nowadays and should work fine in such a > case, though :)
Fwiw, I can't remember either why it had to be flush_work_sync() here. The initial soc-core stuff was 5 years ago and the reason is well and truly forgotten ;-)
Thanks
Liam -- Freelance Developer, SlimLogic Ltd ASoC and Voltage Regulator Maintainer. http://www.slimlogic.co.uk
| |