lkml.org 
[lkml]   [2010]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 9/9] ARM i.MX51 babbage: Add framebuffer support
    On Sun, Dec 12, 2010 at 09:37:38AM +0800, Liu Ying wrote:
    > Hello, Sascha,
    >
    > I have following 3 comments to this patch:
    > 1) I think DISP1_DATx pins need not be set specially, as they keep the
    > default register values.

    We do not want to depend on default register values in the Linux Kernel.

    > 2) Please define 'MX51_PAD_DI_GP4__IPU_DI2_PIN15' in
    > arch/arm/plat-mxc/include/mach/iomux-mx51.h, and rename the pin to be
    > 'MX51_PAD_DI_GP4__DI2_PIN15', as we name it according to the MX51
    > iomux reference manual.

    I'm not sure. Normally it's good practice to code the unit into the
    name. Otherwise we end up with names like MX51_PAD_xyz__TX which could
    be the tx pin of just about any unit.


    > 3) It is better to exchange the following two lines or just remove the
    > first line:
    > + gpio_set_value(GPIO_DVI_RESET, 0);
    > + gpio_direction_output(GPIO_DVI_RESET, 0);

    ok.

    Sascha


    --
    Pengutronix e.K. | |
    Industrial Linux Solutions | http://www.pengutronix.de/ |
    Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
    Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |


    \
     
     \ /
      Last update: 2010-12-13 12:45    [W:0.025 / U:63.144 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site