lkml.org 
[lkml]   [2010]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 2/2] scsi: don't use execute_in_process_context()
    From
    Date
    On Tue, 2010-10-19 at 14:58 +0200, Tejun Heo wrote:
    > SCSI is the only subsystem which uses execute_in_process_context().
    > With the recent workqueue updates, unconditionally using work wouldn't
    > cause deadlocks around execution resources and the two places where
    > SCSI uses them are cold paths where using work unconditionally
    > wouldn't make any difference. Drop execute_in_process_context() and
    > use work directly.

    Sorry, managed to lose this until the ping.

    The analysis above isn't quite correct, I'm afraid. We use the
    execute_in_process_context() not to avoid deadlocks, but to acquire
    process context if we don't have it because the API allows calling from
    sites at interrupt context. The point of using
    execute_in_process_context() is that we actually want to make use of the
    user context if we have one ... there's no point using a workqueue in
    that case, because there's nothing to be gained (except to slow
    everything down). We have no ordering constraints (the traditional
    reason for using workqueues) so this is purely about context.

    Alan stern recently did an analysis (at least for the target reap) that
    says we actually have no interrupt context call sites, so abandoning the
    execute_in_process_context() for a direct call in that case might make
    sense.

    James




    \
     
     \ /
      Last update: 2010-12-12 23:51    [W:0.021 / U:91.596 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site