Messages in this thread Patch in this message | | | From | Andy Shevchenko <> | Subject | [resend][PATCH] fs: use kernel's hex_to_bin() method | Date | Fri, 10 Dec 2010 12:55:05 +0200 |
| |
Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com> Cc: Alexander Viro <viro@zeniv.linux.org.uk> Cc: linux-fsdevel@vger.kernel.org --- fs/binfmt_misc.c | 7 +++---- 1 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/fs/binfmt_misc.c b/fs/binfmt_misc.c index 1befe2e..a0fb271 100644 --- a/fs/binfmt_misc.c +++ b/fs/binfmt_misc.c @@ -28,6 +28,7 @@ #include <linux/mount.h> #include <linux/syscalls.h> #include <linux/fs.h> +#include <linux/kernel.h> #include <asm/uaccess.h> @@ -244,10 +245,8 @@ static int unquote(char *from) while ((c = *s++) != '\0') { if (c == '\\' && *s == 'x') { s++; - c = toupper(*s++); - *p = (c - (isdigit(c) ? '0' : 'A' - 10)) << 4; - c = toupper(*s++); - *p++ |= c - (isdigit(c) ? '0' : 'A' - 10); + *p = hex_to_bin(*s++) << 4; + *p++ |= hex_to_bin(*s++); continue; } *p++ = c; -- 1.7.2.3
| |