Messages in this thread | | | Subject | Re: [PATCH] at91: Refactor Stamp9G20 and PControl G20 board file | From | Igor Plyatov <> | Date | Fri, 10 Dec 2010 09:19:58 +0300 |
| |
Dear Christian,
> As PControl G20 is a carrier board for the Stamp9G20 SoM, some code can > be shared. Therefore board-stamp9g20.c is refactored to allow reusing the > SoM initialization and board-pcontrol-g20.c is modified to use it. > > Signed-off-by: Christian Glindkamp <christian.glindkamp@taskit.de> > --- > > How about this approach? Compile tested for PControl G20 and run time tested > for Stamp9G20 EVB and PortuxG20. > > Just a side note: PortuxG20 is not a carrier board for the Stamp9G20. It just > shares so much with the evaluation board, that it makes sense to put them both > into the same file. And there is no intention to put other boards into this > file.
The idea from this patch is clean. Yours patch does not apply to the kernel from git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git, but I apply its content by hands and kernels compiled successfully with stamp9g20_defconfig and pcontrol_g20_defconfig.
Please run ./scripts/checkpatch.pl with you patch and correct all errors and warnings reported.
If you will correct this patch, to be applicable, then I will vote to include it into mainline.
Which kernel repository and branch should I use for the AT91 ARM? I just want to know - whereto send my next patch to support gms machine?
Best regards! -- Igor Plyatov
| |