Messages in this thread | | | Subject | Re: [RFC][PATCH 02/10] mm: Remove likely() from mapping_unevictable() | From | Steven Rostedt <> | Date | Fri, 10 Dec 2010 19:09:12 -0500 |
| |
On Fri, 2010-12-10 at 17:08 +0900, Miles Bader wrote: > Joe Perches <joe@perches.com> writes: > > It'd be better to use > > > > if (!mapping) > > return 0; > > return test_bit(AS_UNEVICTABLE, &mapping->flags); > > > > to avoid the unnecessary !! > > How about > > return mapping && test_bit(AS_UNEVICTABLE, &mapping->flags); > > instead...?
I'll just add my current patch as a "likely()" clean up. Any other change should be separate.
Thanks,
-- Steve
| |