lkml.org 
[lkml]   [2010]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/8] staging: ft1000: Convert char device to debugfs.
On Fri, Dec 10, 2010 at 12:35:33PM -0500, Dave Jones wrote:
> On Thu, Dec 09, 2010 at 01:43:36PM +0300, Dan Carpenter wrote:
> > > + file = debugfs_create_file("device", S_IRUGO | S_IWUGO, dir,
> > ^^^^^^^
> > > + NULL, &ft1000fops);
> >
> > Don't make this world writeable.
>
> we should probably make checkpatch catch this.
>
>
>
>
> Exporting world writable sysfs/debugfs files is usually a bad thing.
> Warn about it.
>
> Signed-off-by: Dave Jones <davej@redhat.com>

Acked-by: Greg Kroah-Hartman <gregkh@suse.de>



\
 
 \ /
  Last update: 2010-12-10 19:13    [W:0.038 / U:6.092 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site