lkml.org 
[lkml]   [2010]   [Dec]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [Patch] net: kill an RCU warning in inet_fill_link_af()
    From
    Date
    Le mercredi 01 décembre 2010 à 12:18 -0500, Thomas Graf a écrit :
    > On Wed, Dec 01, 2010 at 05:03:06PM +0100, Eric Dumazet wrote:
    > > [PATCH net-next-2.6] net: kill an RCU warning in inet_fill_link_af()
    > >
    > > commits 9f0f7272 (ipv4: AF_INET link address family) and cf7afbfeb8c
    > > (rtnl: make link af-specific updates atomic) used incorrect
    > > __in_dev_get_rcu() in RTNL protected contexts, triggering PROVE_RCU
    > > warnings.
    > >
    > > Switch to __in_dev_get_rtnl(), wich is more appropriate, since we hold
    > > RTNL.
    > >
    > > Based on a report and initial patch from Amerigo Wang.
    >
    > RTNL is not held while dumping, it is only held for get and set, but we
    > still hold rcu readlocks while dumping so there should be no asserts
    > triggered. Thanks for fixing this.

    Are you sure RTNL is not held while dumping ?

    Patrick did the change to hold RTNL while dumping too, 3.5 years ago.
    Check commits 6313c1e0992fea, 1c2d670f3660e9103 ([RTNETLINK]: Hold
    rtnl_mutex during netlink dump callbacks)

    If this was the case (not holding RTNL), we should use
    rcu_dereference(), not rtnl_dereference()



    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-12-01 18:35    [W:0.022 / U:31.700 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site