lkml.org 
[lkml]   [2010]   [Dec]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 3/3] NFS: Fix a memory leak in nfs_readdir
    On 2010-12-01 18:35, Rik van Riel wrote:
    > On 12/01/2010 11:17 AM, Linus Torvalds wrote:
    >
    >> So this is a TOTALLY UNTESTED trivial patch that just adds another
    >> callback. Does this work? I dunno. But I get the feeling that instead
    >> of having NFS work around the odd semantics that don't actually match
    >> what NFS wants, introducing a new callback with much simpler semantics
    >> would be simpler for everybody, and avoid the need for subtle code.
    >
    > Surely somebody can have just looked up the page and
    > gotten a reference count, right before your ->freepage
    > call is invoked?
    >
    > CPU A CPU B
    >
    > look up page
    > grab refcount
    > ->freepage
    >
    > use contents of page
    >
    > Am I overlooking something obvious?
    >

    The page is not cached any more at this point therefore
    looking it up won't find it.

    Benny


    \
     
     \ /
      Last update: 2010-12-01 17:49    [W:3.207 / U:0.520 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site