lkml.org 
[lkml]   [2010]   [Dec]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH net-next-2.6] : __in_dev_get_rtnl() can use rtnl_dereference()
    From
    Date
    Le mercredi 01 décembre 2010 à 12:21 +0100, Eric Dumazet a écrit :

    > Same here. RTNL is held. Please use __in_dev_get_rtnl()

    By the way we can use rtnl_dereference() in __in_dev_get_rtnl()

    [PATCH net-next-2.6] : __in_dev_get_rtnl() can use rtnl_dereference()

    If caller holds RTNL, we dont need a memory barrier
    (smp_read_barrier_depends) included in rcu_dereference().

    Just use rtnl_dereference() to properly document the assertions.

    Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
    ---
    include/linux/inetdevice.h | 2 +-
    1 files changed, 1 insertion(+), 1 deletion(-)

    diff --git a/include/linux/inetdevice.h b/include/linux/inetdevice.h
    index 2b86eaf..ae8fdc5 100644
    --- a/include/linux/inetdevice.h
    +++ b/include/linux/inetdevice.h
    @@ -222,7 +222,7 @@ static inline struct in_device *in_dev_get(const struct net_device *dev)

    static inline struct in_device *__in_dev_get_rtnl(const struct net_device *dev)
    {
    - return rcu_dereference_check(dev->ip_ptr, lockdep_rtnl_is_held());
    + return rtnl_dereference(dev->ip_ptr);
    }

    extern void in_dev_finish_destroy(struct in_device *idev);

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-12-01 12:39    [W:0.025 / U:91.464 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site