Messages in this thread | | | Date | Tue, 9 Nov 2010 14:44:50 -0800 | From | Greg KH <> | Subject | Re: [PATCH] fs, sysfs: Change sysfs_pathname function prototype. |
| |
On Sun, Oct 31, 2010 at 05:48:36PM +0600, Rakib Mullick wrote: > Make sysfs_pathname inline, we we're hit by the following warning: > > > fs/sysfs/dir.c:410: warning: ‘sysfs_pathname’ defined but not used > > > Signed-off-by: Rakib Mullick <rakib.mullick@gmail> > --- > > --- linus-36/fs/sysfs/dir.c 2010-10-21 02:30:22.000000000 +0600 > +++ rakib-36/fs/sysfs/dir.c 2010-10-31 17:34:46.000000000 +0600 > @@ -407,7 +407,7 @@ int __sysfs_add_one(struct sysfs_addrm_c > * > * XXX: does no error checking on @path size > */ > -static char *sysfs_pathname(struct sysfs_dirent *sd, char *path) > +static inline char *sysfs_pathname(struct sysfs_dirent *sd, char *path)
If it's really not used then why would marking it inline help out any? Shouldn't we just delete the function instead?
thanks,
greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |