Messages in this thread | | | Subject | Re: [PATCH V2] include/linux/kernel.h: Move logging bits to include/linux/logging.h | From | Joe Perches <> | Date | Tue, 09 Nov 2010 12:30:19 -0800 |
| |
On Tue, 2010-11-09 at 12:10 -0800, Joe Perches wrote: > On Tue, 2010-11-09 at 22:01 +0200, Alexey Dobriyan wrote: > > Why linux_proc_banner is moved? > It's only used by a printk.
Checking again, linux_proc_banner is only used in one seq_printf and is not used in a printk.
$ git grep -w linux_proc_banner * fs/proc/version.c: seq_printf(m, linux_proc_banner, include/linux/logging.h:extern const char linux_proc_banner[]; init/version.c:const char linux_proc_banner[] =
I supposed it could be removed from kernel.h or logging.h/printk.h and just declared extern in fs/proc/version.c or moved to init.h or maybe even version.h.
init.h already has other extern variables that are declared in init/main.c so that might make some sense.
| |